[Cryptech Core] proposed core reorganization

[Joachim Strömbergson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Aloha!

Павел Шатов wrote:
> 1. Use conditional synthesis and instantiate appropriate modules
> inside of hash_selector.v in `ifdef NO	VENA and `ifdef TERASIC
> blocks. I don't know why you dislike conditional synthesis, it is a
> common trick. Yes, it looks ugly at times, but universality involves
> increased complexity, you can't do anything about it.

Yes, I dislike conditional synthesis. I usually do it by separate scripts.


> 2. Make hash_selector_novena.v that instantiates novena_regs.v and 
> hash_selector_terasic.v that instantiates terasic_regs.v. This way
> hash selector becomes in fact platform-specific and your decision to
> place core_selector under platform makes even more sense.

If possible, those registers should really be in the EIM and/or
queue/clock domain crossing modules, not in core_selector. The
core_selector is (should be) basically an address decoded and mux and
not have tech specific instances.


> 
> -- With best regards, Pavel Shatov 
> _______________________________________________ Core mailing list 
> Core at cryptech.is https://lists.cryptech.is/listinfo/core


- -- 
Med vänlig hälsning, Yours

Joachim Strömbergson - Alltid i harmonisk svängning.
========================================================================
 Joachim Strömbergson          Secworks AB          joachim at secworks.se
========================================================================
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJU+E6MAAoJEF3cfFQkIuyNVOsQAKu7qetpaFbHdJY9QCtzy0Lo
e6zCudHGuHriz49Dv3Bn8dVg3pJw1IGoIiCjDXCmTMHA4D0DQmRf5zV8vUn2YhcN
NwWBpVzvVxNXvGg8fdKw9d3B3d4Ni+sSJkj9v9ke4WYVaOlUJJ3sD8GUqnzyve+c
AxXJLLqre723G7D3PLGFip6SNGfzVxjYFKJa4nrnRXnXP5MDDc09MiFU9duWL8vE
5W6v3ufGbILOfqRXl5iVXd6UOPluEcwyByRISLSVdPAjD2dEUeI9qOQ28bLzOMx1
TYWm/C99j8IpOSgOMIf+8U2j1YdaUveBMHj8/bM8bnPVQzrmfOIC4s8CZG+AKJ4Q
ZC85XxIrDsylmGX5MuYpSjjI30z4IH/NUiNZdMec7KehMK4c2DqVKTJVAOsLnd08
9+hxWgRGvjaPZ9RDi8lr90vEYGR9foCZDh5RwQRApoEEguWrtY3Grk5H6p+U3Uuq
8ZjiImBLn8SovYFB3m0sKgJRu7TFziokGDEmKEKsXFeyFbrWboAgt+hnQE437tte
mTZgj7skIKZq6XSnqi6u+CMNLJ0AwdgDZeZ4iz99lJh5Syt/YDCYgE9nRtzQZdBf
W9+JURYCLYP4gJZlHBOSZj6QgSRa/dm33tBY/bGpTYKxSQOQ5HQ0GeBx4bytrPfk
X3fd5dY8xQBc2o/UuJ8g
=LxD/
-----END PGP SIGNATURE-----