[Cryptech-Commits] [sw/libhal] 04/05: Fencepost error in hal_uuid_format().

git at cryptech.is git at cryptech.is
Fri Sep 2 19:19:47 UTC 2016


This is an automated email from the git hooks/post-receive script.

sra at hactrn.net pushed a commit to branch ksng
in repository sw/libhal.

commit b15af56c7d343eabac35bd7cb9eb793f934c058a
Author: Rob Austein <sra at hactrn.net>
AuthorDate: Fri Sep 2 14:55:05 2016 -0400

    Fencepost error in hal_uuid_format().
---
 uuid.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/uuid.c b/uuid.c
index be13356..8b82066 100644
--- a/uuid.c
+++ b/uuid.c
@@ -93,11 +93,11 @@ hal_error_t hal_uuid_format(const hal_uuid_t * const uuid, char *buffer, const s
   if (uuid == NULL || buffer == NULL || buffer_len < HAL_UUID_TEXT_SIZE)
     return HAL_ERROR_BAD_ARGUMENTS;
 
-  if (buffer_len != snprintf(buffer, buffer_len, fmt,
-			     uuid->uuid[ 0], uuid->uuid[ 1], uuid->uuid[ 2], uuid->uuid[ 3],
-			     uuid->uuid[ 4], uuid->uuid[ 5], uuid->uuid[ 6], uuid->uuid[ 7],
-			     uuid->uuid[ 8], uuid->uuid[ 9], uuid->uuid[10], uuid->uuid[11],
-			     uuid->uuid[12], uuid->uuid[13], uuid->uuid[14], uuid->uuid[15]))
+  if (snprintf(buffer, buffer_len, fmt,
+               uuid->uuid[ 0], uuid->uuid[ 1], uuid->uuid[ 2], uuid->uuid[ 3],
+               uuid->uuid[ 4], uuid->uuid[ 5], uuid->uuid[ 6], uuid->uuid[ 7],
+               uuid->uuid[ 8], uuid->uuid[ 9], uuid->uuid[10], uuid->uuid[11],
+               uuid->uuid[12], uuid->uuid[13], uuid->uuid[14], uuid->uuid[15]) != HAL_UUID_TEXT_SIZE - 1)
     return HAL_ERROR_RESULT_TOO_LONG;
 
   return HAL_OK;



More information about the Commits mailing list