[Cryptech-Commits] [sw/libhal] branch ksng updated: Remove now-gratuitous check which kept attribute deletion from working.

[git at cryptech.is]

This is an automated email from the git hooks/post-receive script.

sra at hactrn.net pushed a commit to branch ksng
in repository sw/libhal.

The following commit(s) were added to refs/heads/ksng by this push:
     new 58a9ca8  Remove now-gratuitous check which kept attribute deletion from working.
58a9ca8 is described below

commit 58a9ca87db1a8d9e75f830a508ab1040c1bd889f
Author: Rob Austein <sra at hactrn.net>
AuthorDate: Mon Nov 14 00:23:26 2016 -0500

    Remove now-gratuitous check which kept attribute deletion from working.
    
    This check made sense when attribute deletion was a separate
    operation, but now that it has been folded into set_attributes(), this
    check was worse than useless.
---
 hal_internal.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/hal_internal.h b/hal_internal.h
index dc00568..756de90 100644
--- a/hal_internal.h
+++ b/hal_internal.h
@@ -666,10 +666,6 @@ static inline  hal_error_t hal_ks_set_attributes(hal_ks_t *ks,
   if (ks->driver->set_attributes == NULL)
     return HAL_ERROR_NOT_IMPLEMENTED;
 
-  for (int i = 0; i < attributes_len; i++)
-    if (attributes[i].length == 0 || attributes[i].value == NULL)
-      return HAL_ERROR_BAD_ARGUMENTS;
-
   return ks->driver->set_attributes(ks, slot, attributes, attributes_len);
 }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.